fix: include types/readable-stream as a dependency #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type definitions for the Metrics client are incomplete without this dependency, and the fix is hard to identify from the error messages. This is technically not a runtime dependency, and affects only a subset of our users, but this makes the module much easier to consume as TypeScript and/or JSDoc typechecking users.
wkillerud
requested review from
digitalsadhu,
flatoy,
leftieFriele and
tor0405
leftieFriele
approved these changes
Nov 4, 2024
Contributor
leftieFriele
left a comment
leftieFriele
left a comment
There was a problem hiding this comment.
I second this, as it seems kind of pointless to force others to add this rather strange dependency in their projects because they pull in @metrics/client
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
## [2.5.4](v2.5.3...v2.5.4) (2024-11-13) ### Bug Fixes * include types/readable-stream as a dependency ([#111](#111)) ([7a4f9d4](7a4f9d4))
|
🎉 This PR is included in version 2.5.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type definitions for the Metrics client are incomplete without this dependency, and the fix is hard to identify from the error messages. This is technically not a runtime dependency, and affects only a subset of our users, but this makes the module much easier to consume as TypeScript and/or JSDoc typechecking users.
See for instance podium-lib/http-client#14